]> Untitled Git - bdk/commitdiff
Merge bitcoindevkit/bdk#2170: fix(chain): add missing `continue` in `CanonicalIter...
authormerge-script <valuedmammal@protonmail.com>
Thu, 16 Apr 2026 16:45:57 +0000 (12:45 -0400)
committermerge-script <valuedmammal@protonmail.com>
Thu, 16 Apr 2026 16:45:57 +0000 (12:45 -0400)
27ab7ee0f212d9853fcff693f3bc22f9c6956105 fix(chain): add missing `continue` in `CanonicalIter` assumed-tx processing (Elias Rohrer)
c4c87c51a3ea5262ea195cc895ecb0ae3235f739 ci: pin `hyper-rustls` to 0.27.7 for 1.75.0 toolchain (valued mammal)

Pull request description:

  ### Description
  Without the `continue`, the loop falls through to the subsequent processing blocks when assumed-canonical transactions are the only remaining unprocessed source. If the anchored, seen, and leftover iterators are all exhausted, the loop reaches `return None` and silently drops the assumed transactions that were just marked canonical.

  ### Notes to the reviewers

Co-Authored-By: HAL 9000
  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 27ab7ee0f212d9853fcff693f3bc22f9c6956105

Tree-SHA512: 9d06d6b254c51144b174d61859cc6e5b5f8b803324925e2091c4ac438b3dd86d2a9c8312ace8785d4c1d04f533869c2036b2999f02f886c05bff698e6a582a14


Trivial merge