]> Untitled Git - bdk/commitdiff
Remove redundant Box around address validators
authorLLFourn <lloyd.fourn@gmail.com>
Tue, 3 Nov 2020 05:03:04 +0000 (16:03 +1100)
committerLLFourn <lloyd.fourn@gmail.com>
Tue, 3 Nov 2020 05:06:43 +0000 (16:06 +1100)
examples/address_validator.rs
src/wallet/address_validator.rs
src/wallet/mod.rs

index f5b3d3cce8147bb917273c76896c03f7ee5a021a..d37049c6baf0a3f7dc4574f14e754a36899d327e 100644 (file)
@@ -62,7 +62,7 @@ fn main() -> Result<(), bdk::Error> {
     let mut wallet: OfflineWallet<_> =
         Wallet::new_offline(descriptor, None, Network::Regtest, MemoryDatabase::new())?;
 
-    wallet.add_address_validator(Arc::new(Box::new(DummyValidator)));
+    wallet.add_address_validator(Arc::new(DummyValidator));
 
     wallet.get_new_address()?;
     wallet.get_new_address()?;
index 385977d785905ff40340e037c7a79980d2a40e02..1a76feb93e06b4efb78d0f4e08154754a33d2f04 100644 (file)
@@ -67,7 +67,7 @@
 //!
 //! let descriptor = "wpkh(tpubD6NzVbkrYhZ4Xferm7Pz4VnjdcDPFyjVu5K4iZXQ4pVN8Cks4pHVowTBXBKRhX64pkRyJZJN5xAKj4UDNnLPb5p2sSKXhewoYx5GbTdUFWq/*)";
 //! let mut wallet: OfflineWallet<_> = Wallet::new_offline(descriptor, None, Network::Testnet, MemoryDatabase::default())?;
-//! wallet.add_address_validator(Arc::new(Box::new(PrintAddressAndContinue)));
+//! wallet.add_address_validator(Arc::new(PrintAddressAndContinue));
 //!
 //! let address = wallet.get_new_address()?;
 //! println!("Address: {}", address);
@@ -140,7 +140,7 @@ mod test {
     #[should_panic(expected = "InvalidScript")]
     fn test_address_validator_external() {
         let (mut wallet, _, _) = get_funded_wallet(get_test_wpkh());
-        wallet.add_address_validator(Arc::new(Box::new(TestValidator)));
+        wallet.add_address_validator(Arc::new(TestValidator));
 
         wallet.get_new_address().unwrap();
     }
@@ -149,7 +149,7 @@ mod test {
     #[should_panic(expected = "InvalidScript")]
     fn test_address_validator_internal() {
         let (mut wallet, descriptors, _) = get_funded_wallet(get_test_wpkh());
-        wallet.add_address_validator(Arc::new(Box::new(TestValidator)));
+        wallet.add_address_validator(Arc::new(TestValidator));
 
         let addr = testutils!(@external descriptors, 10);
         wallet
index 881a2710ab1fbc917b03f9f541fd675e45953d15..16b9d88b3023b12a61d82ee8c6289e5e3570f436 100644 (file)
@@ -89,7 +89,7 @@ pub struct Wallet<B: BlockchainMarker, D: BatchDatabase> {
     signers: Arc<SignersContainer>,
     change_signers: Arc<SignersContainer>,
 
-    address_validators: Vec<Arc<Box<dyn AddressValidator>>>,
+    address_validators: Vec<Arc<dyn AddressValidator>>,
 
     network: Network,
 
@@ -218,7 +218,7 @@ where
     /// Add an address validator
     ///
     /// See [the `address_validator` module](address_validator) for an example.
-    pub fn add_address_validator(&mut self, validator: Arc<Box<dyn AddressValidator>>) {
+    pub fn add_address_validator(&mut self, validator: Arc<dyn AddressValidator>) {
         self.address_validators.push(validator);
     }