From: 志宇 Date: Wed, 21 Oct 2026 03:30:26 +0000 (+0000) Subject: ci: only build the libraries on MSRV X-Git-Url: http://internal-gitweb-vhost/-script/src/example_cli/database/enum.AnyDatabase.html?a=commitdiff_plain;h=7bd52322f8b1322c3f11ec8a604401ca21de5f73;p=bdk ci: only build the libraries on MSRV The MSRV job also built every target and ran the tests on 1.85.0, so test-only dependencies (e.g. `proptest`) had to be pinned in `pin-msrv.sh` too. The MSRV promise only covers building the published libraries, so build those (`--lib`) and leave tests to the jobs on `rust-version`. Drop the `proptest` pin. Co-Authored-By: Claude Opus 5.5 --- diff --git a/.github/workflows/cont_integration.yml b/.github/workflows/cont_integration.yml index 25cffe9e..e4e788f0 100644 --- a/.github/workflows/cont_integration.yml +++ b/.github/workflows/cont_integration.yml @@ -34,11 +34,9 @@ jobs: - name: Pin dependencies for MSRV run: ./ci/pin-msrv.sh - name: Build 1.85.0 (no default features) - run: cargo build --workspace --all-targets --no-default-features + run: cargo build --workspace --lib --no-default-features - name: Build 1.85.0 (all features) - run: cargo build --workspace --all-targets --all-features - - name: Test 1.85.0 (all features) - run: cargo test --workspace --lib --tests --all-features + run: cargo build --workspace --lib --all-features build-core: needs: prepare diff --git a/README.md b/README.md index 5c5c5e07..76a55758 100644 --- a/README.md +++ b/README.md @@ -55,7 +55,7 @@ To report a security issue, please refer to the [security policy](SECURITY.md). ## Minimum Supported Rust Version (MSRV) -The following BDK crates maintains a MSRV of 1.85.0. To build these crates with the MSRV of 1.85.0 you will need to pin dependencies by running the [`pin-msrv.sh`](./ci/pin-msrv.sh) script. +The following BDK crates maintains a MSRV of 1.85.0. To build these crates with the MSRV of 1.85.0 you will need to pin dependencies by running the [`pin-msrv.sh`](./ci/pin-msrv.sh) script. The MSRV only covers building the libraries; tests and examples need the toolchain in [`rust-version`](./rust-version). - `bdk_core` - `bdk_chain` @@ -63,6 +63,7 @@ The following BDK crates maintains a MSRV of 1.85.0. To build these crates with - `bdk_esplora` - `bdk_file_store` - `bdk_electrum` +- `bdk_testenv` ## Just diff --git a/ci/pin-msrv.sh b/ci/pin-msrv.sh index 1529c380..703558e4 100755 --- a/ci/pin-msrv.sh +++ b/ci/pin-msrv.sh @@ -15,4 +15,3 @@ cargo update -p icu_normalizer --precise "2.1.1" cargo update -p icu_provider --precise "2.1.1" cargo update -p icu_locale_core --precise "2.1.1" cargo update -p yoke-derive --precise "0.8.2" -cargo update -p proptest --precise "1.11.0"