]> Untitled Git - bdk-cli/commit
fix(combine_psbt): Propagate Psbt::combine errors
authorVihiga Tyonum <withtvpeter@gmail.com>
Wed, 16 Sep 2026 10:49:59 +0000 (11:49 +0100)
committerVihiga Tyonum <withtvpeter@gmail.com>
Wed, 16 Sep 2026 10:57:08 +0000 (11:57 +0100)
commit682e4148b1994c452dd8619f5a5c43a8ef135e2d
treea59fd895061b462ba3b95b541d9f4a063232b733
parent20d69a17291ed23824b070fa2b7338eb7c14f8ac
fix(combine_psbt): Propagate Psbt::combine errors

The fold merging the input PSBTs discarded each combine result with
`let _ = acc.combine(x)`. Per BIP174, Psbt::combine returns Err whenever
the two PSBTs do not describe the same unsigned transaction, so
incompatible inputs left the accumulator untouched.

This fix propagates the error with `?`. BDKCliError already converts from
bitcoin::psbt::Error, so the command now exits non-zero.

Fixes #323
src/handlers/offline.rs
tests/integration/online.rs