]> Untitled Git - bdk-cli/commit
Merge bitcoindevkit/bdk-cli#135: adding hardware signers
authorrajarshimaitra <rajarshi149@gmail.com>
Wed, 8 Mar 2023 05:39:11 +0000 (11:09 +0530)
committerrajarshimaitra <rajarshi149@gmail.com>
Wed, 8 Mar 2023 05:39:18 +0000 (11:09 +0530)
commite3d09a6f0bc16a60e4796be2b4179aeb294502b3
treed79dd8ae41f52e797983da90fdf11126a29eab25
parent7b0b47972b2302e3db500bcc66351904bf7acd2b
parent100ea8d7e8ae789e3c328706591ec20ba427496b
Merge bitcoindevkit/bdk-cli#135: adding hardware signers

100ea8d7e8ae789e3c328706591ec20ba427496b adding hardware signers (Richard Ulrich)

Pull request description:

  ### Description

  Adding hardware signers, so that hardware wallets can be used to sign transactions.

  ### Notes to the reviewers

  ~~It doesn't work 100% yet for me.
  I am using the following wallet:
  https://github.com/RCasatta/electrum2descriptors/blob/main/tests/wallets2descriptors.rs#L89
  https://github.com/RCasatta/electrum2descriptors/blob/main/tests/wallets/multisig_hw_segwit
  I can create and sign a transaction with this version of bdk-cli. It displays the details on the Trezor and everything looks good so far. But in the CLI output of bdk-cli it says  "is_finalized= false" and when I open the supposedly signed tx in Electrum, it aslo says "Status: Unsigned".
  So, something must still be missing.~~

  Initially I had some dependency problems, so I deleted Cargo.lock. That solved the dependency problems, but that's the reason for the large diff on that file.

  ## Changelog notice

  Added hardware signers through the use of HWI

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature
  * [x] I've updated `CHANGELOG.md`

ACKs for top commit:
  notmandatory:
    utACK 100ea8d7e8ae789e3c328706591ec20ba427496b
  rajarshimaitra:
    ACK 100ea8d7e8ae789e3c328706591ec20ba427496b

Tree-SHA512: 672c72f7d23aa80db638562cd48ab377712d3600f360ee4dbfa34537b7f15c91c647f38493d82300acf9c04398f3a104f2ab3951aff2dac6dbc94a284ac16934
Cargo.lock
Cargo.toml