]> Untitled Git - bdk/commit
Merge bitcoindevkit/bdk#1993: keychain_txout: `apply_changeset` restores spk cache...
authormerge-script <valuedmammal@protonmail.com>
Thu, 17 Jul 2025 18:27:11 +0000 (14:27 -0400)
committermerge-script <valuedmammal@protonmail.com>
Thu, 17 Jul 2025 18:27:11 +0000 (14:27 -0400)
commitedf0279a30a3df11734005688999befaa4052f70
treea9a5ba9851753da851b13c935e017a0026ab2acd
parentd9c2b95512608f694a177b823b163f67c3326e15
parent6ddecc983ab3fb163303af4902bd10cf7e4a1fdf
Merge bitcoindevkit/bdk#1993: keychain_txout: `apply_changeset` restores spk cache before last revealed

6ddecc983ab3fb163303af4902bd10cf7e4a1fdf refactor(keychain_txout): `apply_changeset` restores spk cache before last revealed (valued mammal)

Pull request description:

  This patch improves readability and maintains logical consistency with the use of `spk_cache` throughout the `keychain_txout` module.

  While it might offer a performance benefit, the results are mostly comparable with the current benchmarks as far as I can tell. At least there's no indication that it would negatively impact performance.

  fixes #1975

  ### Changelog notice

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  LagginTimes:
    ACK 6ddecc983ab3fb163303af4902bd10cf7e4a1fdf

Tree-SHA512: 4c11d049f94f332c88c63687d5147d25cc372d65b5f1d9d9c8784e1310e0f03e9aee479b684c255dbebb1510a7922331ad07cbcbdf47d534cf28ea8ee0e1be66