]> Untitled Git - bdk/commit
Merge bitcoindevkit/bdk#1090: fix(electrum): Don't ignore multiple coinbase txs github/release/0.28
authorSteve Myers <steve@notmandatory.org>
Tue, 22 Aug 2023 17:28:36 +0000 (12:28 -0500)
committerSteve Myers <steve@notmandatory.org>
Tue, 22 Aug 2023 17:29:46 +0000 (12:29 -0500)
commite3ca356caec436520e0b433e081f3ff591c1d069
treefc3568a804b820399af5df903d7d5b2630261e2d
parentd1af252ac43d79e17a2751cfefea0e4596e0a02a
parent530ba36b07f2cddad90b844ef1a56cb27ee1cf74
Merge bitcoindevkit/bdk#1090: fix(electrum): Don't ignore multiple coinbase txs

530ba36b07f2cddad90b844ef1a56cb27ee1cf74 ci: fix msrv dependency versions for reqest and h2 (Daniela Brozzoni)
7a359d5eef66e60e0ab604fb0d043c2db260252d fix(electrum): Don't ignore multiple coinbase txs (Daniela Brozzoni)

Pull request description:

  We would previously insert just one coinbase transaction in the database if we caught multiple in the same sync.
  When we sync with electrum, before committing to the database, we remove from the update conflicting transactions, using the `make_txs_consistent` function. This function considers two txs to be conflicting if they spend from the same outpoint - but every coinbase transaction spends from the same outpoint!
  Here we make sure to avoid filtering out coinbase transactions, by adding a check on the txid just before we do the filtering.

  Fixes #1051

  ### Changelog notice

  - Fix a bug when syncing coinbase utxos on electrum

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    tACK 530ba36b07f2cddad90b844ef1a56cb27ee1cf74

Tree-SHA512: ebbc6af86d4433ac4083212033a23f183d109641db345cc06ab4d506995ab71657761351c03772462ab4ff0d081226ecc97f1042490194aaf8661914cbeb72cb