]> Untitled Git - bdk-cli/commitdiff
Merge bitcoindevkit/bdk-cli#82: [bug fix] Add `maybe_descriptor_wallet_name()` in...
authorSteve Myers <steve@notmandatory.org>
Tue, 29 Mar 2022 22:14:59 +0000 (15:14 -0700)
committerSteve Myers <steve@notmandatory.org>
Tue, 29 Mar 2022 22:16:09 +0000 (15:16 -0700)
fd3f2b4c1188abb0a70946ec651bfb9c03220857 Fix repl error and help printing (Steve Myers)
e4eda39e01063c506cd1ad43be1294f360c7bdb9 Add `maybe_descriptor_wallet_name()` is repl mode (rajarshimaitra)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Because we didn't had `maybe_descriptor_wallet_name()` in repl, the following command would fail
  ```
  $ ./target/debug/bdk-cli repl -d "wpkh([b8b575c2/84'/1'/0'/0]tprv8icWtRzy9CWgFxpGMLSdAeE4wWyz39XGc6SwykeTo13tYm14JkVVQAf7jz8WDDarCgNJrG3aEPJEqchDWeJdiaWpS3FwbLB9SzsN57V7qxB/*)"
  thread 'main' panicked at 'We should always have a wallet name at this point', src/bdk_cli.rs:116:10
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  ```

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    tACK fd3f2b4c1188abb0a70946ec651bfb9c03220857

Tree-SHA512: 80008f089b882b5139ea127b734e38553877a8b0688e123f0f3f25a2f01a74a0ce1d842df00b55148a3825eba552cf8e9ff4cbf96b4275176494884b24814203


Trivial merge