From: Steve Myers <steve@notmandatory.org>
Date: Sun, 13 Apr 2025 02:55:49 +0000 (-0500)
Subject: Merge bitcoindevkit/bdk-cli#174: feature: update `bdk-cli` to use `bdk_wallet` v1
X-Git-Tag: v1.0.0~7
X-Git-Url: http://internal-gitweb-vhost/?a=commitdiff_plain;h=2fa18a02c22b9aedf1ebaba643221593db3b129b;p=bdk-cli

Merge bitcoindevkit/bdk-cli#174: feature: update `bdk-cli` to use `bdk_wallet` v1

e0bd1471c88cbadc12558328b236ba6923f86cc9 fix: clippy errors (Steve Myers)
524562cd10b39b0b1cb3ef63f21ba985268bff03 fix: signing / finalizing `psbt` (Vihiga Tyonum)
fb7232f36bd1ffd44ffefa5e4b105329cecf7a05 rpc: print status during full_scan and sync (Steve Myers)
4a66557828a64734130ed2050a05827874161d3e ci: remove WASM job, fix more clippy errors (Steve Myers)
eb947fc30d26c4dcc4f0ba5082223e42c768a4cf ci: with msrv 1.75 pin minreq to 2.13.2 (Steve Myers)
efc5fc5a15650e804215a516cdf9e624d19bb5c3 ci: fix clippy errors (Steve Myers)
92cabb119f7aa16a5f018be518659499ee7228b7 ci: update actions checkout and cache to v4, simplify matrix features (Steve Myers)
cb108738f8d795d431b910146685386bb8d41094 refactor: fix error handling (Vihiga Tyonum)
8307db08776d7b53dbadcf776a4b786a925291f2 feat: re-enable `rpc` feature (Vihiga Tyonum)
8ac25291e955a87f8a97348f6577a91d716a8af0 ci: update the CI workflow (Vihiga Tyonum)
a2ad6b3b72b2377036c3ba761befc0cc7418b23b feat: add ci test for features (Vihiga Tyonum)
50a6a60f35d251687bd464b379012d961bdf5a7d refactor: remove rpc, cbf, cleanup features (Steve Myers)
0be8453c54fc747c3c4e06b665c100bc0ee7bea6 refactor: update onlinewalletsubcommands (Vihiga Tyonum)
440bd3687bb8e91b71c72bc0a3d8219e25051044 refactor: update creating_backend fn (Vihiga Tyonum)
58f07a1c0bdaddb354111b709243a8c08904e147 refactor: update nodes.rs file (Vihiga Tyonum)
cb4450b9112dba4fecb8be2b0c739778b3bfc57b refactor: update imports and reserves feature (Vihiga Tyonum)
50233dd3fd1b752f209df74813b2dc028105cf6f refactor: replace bdk::error with custom error (Vihiga Tyonum)
b8d235731e9c4b8375d7967d1295e474db8e5259 feat: add custom error enum (Vihiga Tyonum)
6f263bf4f6b80a3b94614b5b336194eeb613498f feat!: replace bdk with bdk_wallet & update deps (Vihiga Tyonum)
b56c0235af1239f59dbfbc1ae17b2e7b497f0fd4 refactor: update imports from bdk to bd_wallet (Vihiga Tyonum)
91f5918d71095041574f83375ff7d5740025ca29 refactor: update imports from bdk to bdk_wallet (Vihiga Tyonum)
ddce50d568ee3aa28a58a89a3ba9c0a87ec9beaf refactor: update imports from bdk to bdk_wallet (Vihiga Tyonum)
4c89cbf968938e3253fa683a18badcadd1ad082b refactor:update imports from bdk to use bdk_wallet (Vihiga Tyonum)
890cb45bc70d1d1cc3851a39871426479ba9d7b3 refactor: add bdk_wallet (Vihiga Tyonum)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  This PR update `bdk-cli` to use `bdk_wallet` v1

  Issue: https://github.com/bitcoindevkit/bdk-cli/issues/172#issue-2780523794

  ### Notes to the reviewers
  - replaced `list_transactions` with `transactions`
  - set `enable_rbf` to be `true` by default
  - update creating and serializing Psbts
  - update `new_wallet` to return `PersistedWallet<Connection>`
  - default fee_rate to use FeeRate::BROADCAST_MIN
  - update `zeroize` to version `1.8.1` from `<1.4.0`
  - update `bdk-reserves` from `0.27.1` to `0.29.0`
  - replace `bdk/electrum` with `bdk_electrum` for the `electrum` feature
  - add `bdk_esplora` for the `bdk/use-esplora-ureq` and `bdk/use-esplora-reqwest` features
  - add `bdk_bitcoind_rpc` lib to replace `bdk/rpc` feature
  - add `hwi` library to replace `bdk/hardware-signer` feature

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ## Changelog notice
  - set `enable_rbf` to be `true` by default
  - update using `PartiallySignedTransaction` to `Psbt`
  - default fee_rate to use FeeRate::BROADCAST_MIN
  - update `zeroize` to version `1.8.1` from `<1.4.0`
  - update `bdk-reserves` from `0.27.1` to `0.29.0`
  - replace `bdk/electrum` with `bdk_electrum` for the `electrum` feature
  - replace `bdk/use-esplora-ureq` and `bdk/use-esplora-reqwest`  with `bdk_esplora` lib
  - replace `bdk/rpc` with `bdk_bitcoind_rpc` lib
  - replace  `bdk/hardware-signer` with `hwi` lib

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK e0bd1471c88cbadc12558328b236ba6923f86cc9

Tree-SHA512: cd548805327b55a66be26aa0402ef7a4512a0a75ffdcefa243c86d838d82215a5e4605989436903c135c31902e84cebf8d88197db18df9193d1fc0cb9e0f567f
---

2fa18a02c22b9aedf1ebaba643221593db3b129b