From: merge-script <hello@evanlinjin.me>
Date: Thu, 7 Aug 2025 02:54:37 +0000 (+0000)
Subject: Merge bitcoindevkit/bdk#1998: refactor!: `Box` the changeset of `StoreErrorWithDump`
X-Git-Tag: core-0.6.2~10
X-Git-Url: http://internal-gitweb-vhost/?a=commitdiff_plain;h=c43154de08fb47352763269fb6268c4bff5c33bf;p=bdk

Merge bitcoindevkit/bdk#1998: refactor!: `Box` the changeset of `StoreErrorWithDump`

418753f01eef29b1266cc3aefa512f90060a9797 refactor!: `Box` changeset in `StoreErrorWithDump` (codingp110)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description
  Fixes #1991. As the linked issue mentions `Box`ing helps reduce memory overhead and [limits the size of enums with `StoreErrorWithDump` as variant](https://github.com/bitcoindevkit/bdk_wallet/pull/277#discussion_r2196831262).

  Breaking: The enum `StoreErrorWithDump` and the functions `load`,`dump` and `load_or_create` have been changed.

  ### Changelog Notice
  ```
     Changed
     - `changeset` field of `StoreErrorWithDump` is now of type `Option<Box<C>>`
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  evanlinjin:
    ACK 418753f01eef29b1266cc3aefa512f90060a9797

Tree-SHA512: c09d2b14989f62613283b728cd8f0eec849a2f3980b07e4289d55289a2834b27c32ff0fcb89706c636441c02b385fbb4a4175e93615f6e16fa2e2e0cfb0e4e26
---

c43154de08fb47352763269fb6268c4bff5c33bf