From: rajarshimaitra <rajarshi149@gmail.com>
Date: Wed, 8 Mar 2023 05:39:11 +0000 (+0530)
Subject: Merge bitcoindevkit/bdk-cli#135: adding hardware signers
X-Git-Tag: v0.27.1~1
X-Git-Url: http://internal-gitweb-vhost/?a=commitdiff_plain;h=e3d09a6f0bc16a60e4796be2b4179aeb294502b3;p=bdk-cli

Merge bitcoindevkit/bdk-cli#135: adding hardware signers

100ea8d7e8ae789e3c328706591ec20ba427496b adding hardware signers (Richard Ulrich)

Pull request description:

  ### Description

  Adding hardware signers, so that hardware wallets can be used to sign transactions.

  ### Notes to the reviewers

  ~~It doesn't work 100% yet for me.
  I am using the following wallet:
  https://github.com/RCasatta/electrum2descriptors/blob/main/tests/wallets2descriptors.rs#L89
  https://github.com/RCasatta/electrum2descriptors/blob/main/tests/wallets/multisig_hw_segwit
  I can create and sign a transaction with this version of bdk-cli. It displays the details on the Trezor and everything looks good so far. But in the CLI output of bdk-cli it says  "is_finalized= false" and when I open the supposedly signed tx in Electrum, it aslo says "Status: Unsigned".
  So, something must still be missing.~~

  Initially I had some dependency problems, so I deleted Cargo.lock. That solved the dependency problems, but that's the reason for the large diff on that file.

  ## Changelog notice

  Added hardware signers through the use of HWI

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature
  * [x] I've updated `CHANGELOG.md`

ACKs for top commit:
  notmandatory:
    utACK 100ea8d7e8ae789e3c328706591ec20ba427496b
  rajarshimaitra:
    ACK 100ea8d7e8ae789e3c328706591ec20ba427496b

Tree-SHA512: 672c72f7d23aa80db638562cd48ab377712d3600f360ee4dbfa34537b7f15c91c647f38493d82300acf9c04398f3a104f2ab3951aff2dac6dbc94a284ac16934
---

e3d09a6f0bc16a60e4796be2b4179aeb294502b3
diff --cc Cargo.lock
index 5932f4b,f4af6d2..d586977
--- a/Cargo.lock
+++ b/Cargo.lock
@@@ -1003,9 -1025,32 +1019,32 @@@ source = "registry+https://github.com/r
  checksum = "1885e79c1fc4b10f0e172c475f458b7f7b93061064d98c3293e98c5ba0c8b399"
  dependencies = [
   "autocfg 1.1.0",
 - "hashbrown 0.12.3",
 + "hashbrown",
  ]
  
+ [[package]]
+ name = "indoc"
+ version = "0.3.6"
+ source = "registry+https://github.com/rust-lang/crates.io-index"
+ checksum = "47741a8bc60fb26eb8d6e0238bbb26d8575ff623fdc97b1a2c00c050b9684ed8"
+ dependencies = [
+  "indoc-impl",
+  "proc-macro-hack",
+ ]
+ 
+ [[package]]
+ name = "indoc-impl"
+ version = "0.3.6"
+ source = "registry+https://github.com/rust-lang/crates.io-index"
+ checksum = "ce046d161f000fffde5f432a0d034d0341dc152643b2598ed5bfce44c4f3a8f0"
+ dependencies = [
+  "proc-macro-hack",
+  "proc-macro2",
+  "quote",
+  "syn",
+  "unindent",
+ ]
+ 
  [[package]]
  name = "instant"
  version = "0.1.12"