]> Untitled Git - bdk-cli/commitdiff
Merge bitcoindevkit/bdk-cli#100: Remove some of the reserves and regtest features
authorSteve Myers <steve@notmandatory.org>
Mon, 27 Jun 2022 17:45:36 +0000 (10:45 -0700)
committerSteve Myers <steve@notmandatory.org>
Mon, 27 Jun 2022 17:46:22 +0000 (10:46 -0700)
5b20283f73c2cbb06732fb97cb725dc87673dd44 update CI to remove some features (rajarshimaitra)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Currently the way `ExternalReserves` functionality is written, it can only be used with `electrum` feature. The tests should fail if the implementation behavior is enforced.. Disabling the tests in CI.

  Also removing the `regtest-esplora` features from the tests, because they won't work when #92 lands.

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK 5b20283f73c2cbb06732fb97cb725dc87673dd44.

Tree-SHA512: 09e875376e2a8b1a43c318b66849abdeb518deee32ca39ba1e10c9b9230b4af61a3391e5a1dcad0586643a820eb66fabfea9d2af95f0d97fe8383524c5e050d9


Trivial merge