From: rajarshimaitra <rajarshi149@gmail.com>
Date: Thu, 16 Dec 2021 15:21:18 +0000 (+0530)
Subject: Remove sync verification
X-Git-Tag: v0.17.0~7^2~11
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/%22example_cli/enum.Commands.html/struct.CommandString.html?a=commitdiff_plain;h=98a3b3282a0ff59bbdf900adc765f6912d1975c1;p=bdk

Remove sync verification

The default sync verification is removed from wallet module.
By default sync time verification only makes sense for `electrum` and
`esplora` backend as they are usually untrusted 3rd party services.

script verification for transaction is costly, so removing default
script verification optimizes performance.
---

diff --git a/src/wallet/mod.rs b/src/wallet/mod.rs
index bf7993d4..8c3c968b 100644
--- a/src/wallet/mod.rs
+++ b/src/wallet/mod.rs
@@ -1537,23 +1537,6 @@ where
                 .sync(self.database.borrow_mut().deref_mut(), progress_update,))?;
         }
 
-        #[cfg(feature = "verify")]
-        {
-            debug!("Verifying transactions...");
-            for mut tx in self.database.borrow().iter_txs(true)? {
-                if !tx.verified {
-                    verify::verify_tx(
-                        tx.transaction.as_ref().ok_or(Error::TransactionNotFound)?,
-                        self.database.borrow().deref(),
-                        &self.client,
-                    )?;
-
-                    tx.verified = true;
-                    self.database.borrow_mut().set_tx(&tx)?;
-                }
-            }
-        }
-
         let sync_time = SyncTime {
             block_time: BlockTime {
                 height: maybe_await!(self.client.get_height())?,