From: Daniela Brozzoni Date: Sat, 30 Jul 2022 07:25:42 +0000 (+0200) Subject: Merge bitcoindevkit/bdk#675: Use T: AsRef as param to SqliteDatabase::new X-Git-Tag: v0.21.0~13 X-Git-Url: http://internal-gitweb-vhost/script/%22https:/%22example_cli/enum.Commands.html/struct.CommandStringError.html?a=commitdiff_plain;h=a1477405d1adebd9a95689af17d3912edf1e57ef;p=bdk Merge bitcoindevkit/bdk#675: Use T: AsRef as param to SqliteDatabase::new 558e37afa72b69228fc40cc20be9122b3ea00597 Use T: AsRef as param to SqliteDatabase::new (Vladimir Fomene) Pull request description: This PR fixes #674 ### Description Currently SqliteDatabase::new takes a String as path, with this change, it now accepts any type that implements AsRef. ### Notes to the reviewers ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature * [x] I've updated `CHANGELOG.md` #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [x] I'm linking the issue being fixed by this PR ACKs for top commit: danielabrozzoni: utACK 558e37afa72b69228fc40cc20be9122b3ea00597 Tree-SHA512: c5ff5b60e5904a5b7ef492a1e40296864b6b7506e4c6a187cfab05ef8140d14ddd322d016b4eeb18c5cfca8d4b575370b4f13c6ea7d7374ab0372a3237a5ed94 --- a1477405d1adebd9a95689af17d3912edf1e57ef