Deprecate Database::flush() function

The Database::flush() function is only needed for the sled database on mobile, instead for mobile use the sqlite database.

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 642bcbd0371ca4557290551c0a5a6c0dd7a994a7..3b43faf361d2d58bcd3fda75085dee233f1c8485 100644 (file)
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Add `sqlite-bundled` feature for deployments that need a bundled version of sqlite, ie. for mobile platforms.
 - Added `Wallet::get_signers()`, `Wallet::descriptor_checksum()` and `Wallet::get_address_validators()`, exposed the `AsDerived` trait.
+- Deprecate `database::Database::flush()`, the function is only needed for the sled database on mobile, instead for mobile use the sqlite database.
 
 ## [v0.17.0] - [v0.16.1]
 

diff --git a/src/database/any.rs b/src/database/any.rs
index c4c74dc70c32186ba12e770ed29888697c9fa0e1..b370ded99bcd88a3c7acd498cc0e02e6dde7c0d0 100644 (file)
--- a/src/database/any.rs
+++ b/src/database/any.rs
@@ -61,6 +61,7 @@ macro_rules! impl_from {
 
 macro_rules! impl_inner_method {
     ( $enum_name:ident, $self:expr, $name:ident $(, $args:expr)* ) => {
+        #[allow(deprecated)]
         match $self {
             $enum_name::Memory(inner) => inner.$name( $($args, )* ),
             #[cfg(feature = "key-value-db")]

diff --git a/src/database/mod.rs b/src/database/mod.rs
index ab2fa9b24c2d5dfeb0df7f594ee24da34f2fdbbe..8141ede4fcd404e8cfdc34103a529066ef7cbecd 100644 (file)
--- a/src/database/mod.rs
+++ b/src/database/mod.rs
@@ -159,6 +159,10 @@ pub trait Database: BatchOperations {
     /// It should insert and return `0` if not present in the database
     fn increment_last_index(&mut self, keychain: KeychainKind) -> Result<u32, Error>;
 
+    #[deprecated(
+        since = "0.18.0",
+        note = "The flush function is only needed for the sled database on mobile, instead for mobile use the sqlite database."
+    )]
     /// Force changes to be written to disk
     fn flush(&mut self) -> Result<(), Error>;
 }