From: Antoine Poinsot Date: Sat, 18 Dec 2021 10:06:31 +0000 (+0100) Subject: descriptors: correct 'pkh()' in the compatibility matrix X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/enum.NewError.html?a=commitdiff_plain;h=f6490956209ba3ee962fdce4a9e78bb4fed555c3;p=bitcoindevkit.org descriptors: correct 'pkh()' in the compatibility matrix `pk_h()` is a Miniscript fragment (the equivalent of `pk_k()` for pubkey hashes) which needs a `c:` in order to be a base expression. The documentation was misleadingly implying that Bitcoin Core was using `pkh()` to describe a `pk_h()` fragment, which is wrong (the former is an alias of `c:pk_h()`). The table also doesn't list `pk_k()`. Therefore just list the `pkh()` and `pk()` aliases. --- diff --git a/docs/descriptors/README.md b/docs/descriptors/README.md index 9cd39f6bda..67f064e81a 100644 --- a/docs/descriptors/README.md +++ b/docs/descriptors/README.md @@ -50,7 +50,7 @@ Below are some tables to highlight the differences between Bitcoin Core's descri | Operator | BDK | rust-miniscript | Bitcoin Core | | -------- | --------------- | --------------- | ------------ | | `pk()` | ✓ | ✓ | ✓ | -| `pk_h()` | ✓ | ✓ | ✓ - as `pkh()` | +| `pkh()` | ✓ | ✓ | ✓ | | `older()` | ✓ | ✓ | ✗ | | `after()` | ✓ | ✓ | ✗ | | `sha256()` | ✓ | ✓ | ✗ |