]> Untitled Git - bdk/commit
projects / bdk / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0e6add0) | patch
Do not compare vtable
authorTobin Harding <me@tobin.cc>
Wed, 30 Dec 2020 03:58:42 +0000 (14:58 +1100)
committerTobin Harding <me@tobin.cc>
Wed, 24 Feb 2021 02:30:48 +0000 (13:30 +1100)
commitcb3b8cf21b6bb48d3b28c9e98df06464823bdcb0
tree53221ac600ba084c55681bdac4760a2639d7c9adtree | snapshot
parent0e6add0cfbf0e25f06b354e82a3f4bf704fcbe69commit | diff
Do not compare vtable

Clippy emits error:

 comparing trait object pointers compares a non-unique vtable address

The vtable is an implementation detail, it may change in future. we
should not be comparing vtable addresses for equality. Instead we can
get a pointer to the data field of a fat pointer and compare on that.
src/wallet/signer.rs diff | blob | blame | history
A modern, lightweight, descriptor-based wallet library written in Rust!