]> Untitled Git - bdk/commitdiff
Merge bitcoindevkit/bdk#1549: fix(example_cli): add bitcoin and rand dependencies
authorSteve Myers <steve@notmandatory.org>
Wed, 14 Aug 2024 19:01:34 +0000 (14:01 -0500)
committerSteve Myers <steve@notmandatory.org>
Wed, 14 Aug 2024 19:12:29 +0000 (14:12 -0500)
3675a9e4921f2002f23a32d2f76d65549899edd4 ci: add job to build example-crates independently (Steve Myers)
1adf63cd3bce77b2a6bc2edebf5f54c2d8a191d7 fix(example_cli): add bitcoin and rand dependencies (Steve Myers)

Pull request description:

  ### Description

  Fix building `example_cli` by adding the bitcoin and rand dependencies so it, and the crates that depend on it, can be built independently and not only from the workspace.

  ### Notes to the reviewers

  I also added the  build-examples CI job to verify we can build examples individually.

  ### Changelog notice

  None.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 3675a9e4921f2002f23a32d2f76d65549899edd4
  storopoli:
    ACK 3675a9e4921f2002f23a32d2f76d65549899edd4

Tree-SHA512: c88fdf6cde72959c88c9f4563834824c573afedb1e5136b0f902d919b42b0de18424fb0d05f275c63a0c05da8062dc53ad5825bdc8dc4b12441890e1b799378b


Trivial merge