From: Steve Myers <steve@notmandatory.org>
Date: Wed, 11 Sep 2024 19:37:37 +0000 (-0500)
Subject: Merge bitcoindevkit/bdk#1561: refactor(bdk_hwi): remove `bdk_hwi`, as `HWISigner... 
X-Git-Tag: v1.0.0-beta.3~4
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/constants/static/gitweb.css?a=commitdiff_plain;h=9020f44e6fb85f83b631e594ba5d88267b63fe17;p=bdk

Merge bitcoindevkit/bdk#1561: refactor(bdk_hwi): remove `bdk_hwi`, as `HWISigner`'s being moved to `rust-hwi`

cd8ddfe18441c562342bcaccf7cae3a0d9ebbd92 chore: remove `ci/automation.json` file, used by Dockerfile.ledger (Leonardo Lima)
75c97a6018033bbeaeeba6b69ca74b67dc47161d fix(ci)!: remove `Dockerfile.ledger` and `hwi` steps from coverage step (Leonardo Lima)
b118b82fb08ee661ac10ac1771640b0965cf1ee8 refactor(bdk_hwi)!: remove `bdk_hwi` (Leonardo Lima)
43257cfca6c8c2a3d5dc2b78da455ff9f16da5bd refactor(wallet)!: remove dangling unused `hardwaresigner.rs` file (Leonardo Lima)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->
  fixes #1516
  depends on https://github.com/bitcoindevkit/rust-hwi/pull/104

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  This PR removed the `bdk_hwi` crate, and the dangling `hardwaresigner.rs` file from `bdk_wallet` crate.

  It simplifies the BDK project workspace as it removes the dependency on `rust-hwi`, pyo3 and some required steps on CI.

  The removal is fine, as the `HWISigner` is being moved to `rust-hwi` project instead, please check: https://github.com/bitcoindevkit/rust-hwi/pull/104

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  Please let me know what you think about the removal, and if I missed anything.

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  - Removed dangling unused `hardwaresigner.rs` file from `bdk_wallet` crate.
  - Removed `bdk_hwi` crate, moved to `rust-hwi` project.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK cd8ddfe18441c562342bcaccf7cae3a0d9ebbd92

Tree-SHA512: 43fe716a3f107ae806b1c9bf83bd0a9f403d3c331443d78c9c4c55ac995577fd8b02ba13b77bbadb72b329e0fc94c22a7a9c8b2478ecad303d2c8db28393da2d
---

9020f44e6fb85f83b631e594ba5d88267b63fe17