From: Steve Myers <steve@notmandatory.org>
Date: Tue, 4 Feb 2025 17:11:51 +0000 (-0600)
Subject: Merge bitcoindevkit/bdk#1738: test(core): add unit tests for `merge` trait
X-Git-Tag: bitcoind_rpc-0.18.0~1
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/encode/index.html?a=commitdiff_plain;h=0a11c809e003e11e3d8804117a5119350fb227b1;p=bdk

Merge bitcoindevkit/bdk#1738: test(core): add unit tests for `merge` trait

fcc0a3409aa390e9f32a3308dd5fe0e2e33b9b44 test: add tests for  trait of operations on various data structures, including conflict scenarios and checking for empty structures (pluveto)

Pull request description:

  ### Description

  This update adds unit tests for the `Merge` trait implementations on `BTreeMap`, `BTreeSet`, `Vec`, and tuples. It also includes tests for the `is_empty` and `take` methods to ensure their correct functionality.

  ### Notes to the Reviewers

  - The tests cover basic scenarios for merging collections and checking their emptiness.
  - Consider the potential method name conflict with `BTreeSet`'s existing `take` method.

  ### Changelog Notice

  - Added unit tests for merging functionality and utility methods (`is_empty`, `take`) on various collection types.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits.
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md).
  * [x] I ran `cargo fmt` and `cargo clippy` before committing.

Top commit has no ACKs.

Tree-SHA512: fdcd67ca9127986e9ce9aa9ccc3276aaff127fa9333696c61ff2ca1b37a2ce8f9fe7af8e06ab57dda493741e91fa63a3aba58a1338a17090626225899e6c7588
---

0a11c809e003e11e3d8804117a5119350fb227b1