From: Steve Myers <steve@notmandatory.org>
Date: Fri, 10 Jan 2025 15:39:51 +0000 (-0600)
Subject: Merge bitcoindevkit/bdk#1789: Change default tx to version 2
X-Git-Tag: bitcoind_rpc-0.18.0~12
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/enum.ChildNumber.html?a=commitdiff_plain;h=a5335a18431dfecea1f524af44c953b79a96867c;p=bdk

Merge bitcoindevkit/bdk#1789: Change default tx to version 2

2219b7cd55bfb8023e9b426de0ef118b32bfa372 fix(tx_builder): change default tx to version 2 (benalleng)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  Changes the default version number to version 2 to enchance privacy for the type of wallet used

  Fixes #1676

  ### Changelog notice

  - Changed the default transaction version number in the transaction builder.
  - Updated the test to test for the default transaction number.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK 2219b7cd55bfb8023e9b426de0ef118b32bfa372

Tree-SHA512: 76a2d394318eea94a99c033c3df14d64dbcf96c0f91dba91d2e337b9ecf78302af3d535ab11a74ed7372a521d3bc14c3455b7c8266d79d2995cc7c5da363b426
---

a5335a18431dfecea1f524af44c953b79a96867c