From: 志宇 <hello@evanlinjin.me>
Date: Sun, 18 May 2025 23:52:17 +0000 (+1000)
Subject: feat(core): Add `is_empty` methods to `TxUpdate` and `{}_Response` types
X-Git-Tag: core-0.6.0~3^2
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/enum.FromScriptError.html?a=commitdiff_plain;h=e9263f9b70271cbcfd67c2f5b250c447ba1fd4fe;p=bdk

feat(core): Add `is_empty` methods to `TxUpdate` and `{}_Response` types
---

diff --git a/crates/core/src/spk_client.rs b/crates/core/src/spk_client.rs
index b6a8e020..5f3cef43 100644
--- a/crates/core/src/spk_client.rs
+++ b/crates/core/src/spk_client.rs
@@ -403,6 +403,13 @@ impl<A> Default for SyncResponse<A> {
     }
 }
 
+impl<A> SyncResponse<A> {
+    /// Returns true if the `SyncResponse` is empty.
+    pub fn is_empty(&self) -> bool {
+        self.tx_update.is_empty() && self.chain_update.is_none()
+    }
+}
+
 /// Builds a [`FullScanRequest`].
 ///
 /// Construct with [`FullScanRequest::builder`].
@@ -560,6 +567,15 @@ impl<K, A> Default for FullScanResponse<K, A> {
     }
 }
 
+impl<K, A> FullScanResponse<K, A> {
+    /// Returns true if the `FullScanResponse` is empty.
+    pub fn is_empty(&self) -> bool {
+        self.tx_update.is_empty()
+            && self.last_active_indices.is_empty()
+            && self.chain_update.is_none()
+    }
+}
+
 struct KeychainSpkIter<'r, K> {
     keychain: K,
     spks: Option<&'r mut Box<dyn Iterator<Item = Indexed<ScriptBuf>> + Send>>,
diff --git a/crates/core/src/tx_update.rs b/crates/core/src/tx_update.rs
index 89a224fb..9be91f1b 100644
--- a/crates/core/src/tx_update.rs
+++ b/crates/core/src/tx_update.rs
@@ -64,6 +64,17 @@ impl<A> Default for TxUpdate<A> {
     }
 }
 
+impl<A> TxUpdate<A> {
+    /// Returns true if the `TxUpdate` contains no elements in any of its fields.
+    pub fn is_empty(&self) -> bool {
+        self.txs.is_empty()
+            && self.txouts.is_empty()
+            && self.anchors.is_empty()
+            && self.seen_ats.is_empty()
+            && self.evicted_ats.is_empty()
+    }
+}
+
 impl<A: Ord> TxUpdate<A> {
     /// Transforms the [`TxUpdate`] to have `anchors` (`A`) of another type (`A2`).
     ///
diff --git a/crates/core/tests/test_spk_client.rs b/crates/core/tests/test_spk_client.rs
new file mode 100644
index 00000000..38766ac3
--- /dev/null
+++ b/crates/core/tests/test_spk_client.rs
@@ -0,0 +1,13 @@
+use bdk_core::spk_client::{FullScanResponse, SyncResponse};
+
+#[test]
+fn test_empty() {
+    assert!(
+        FullScanResponse::<(), ()>::default().is_empty(),
+        "Default `FullScanResponse` must be empty"
+    );
+    assert!(
+        SyncResponse::<()>::default().is_empty(),
+        "Default `SyncResponse` must be empty"
+    );
+}
diff --git a/crates/core/tests/test_tx_update.rs b/crates/core/tests/test_tx_update.rs
new file mode 100644
index 00000000..d5d2dbc3
--- /dev/null
+++ b/crates/core/tests/test_tx_update.rs
@@ -0,0 +1,9 @@
+use bdk_core::TxUpdate;
+
+#[test]
+fn test_empty() {
+    assert!(
+        TxUpdate::<()>::default().is_empty(),
+        "Default `TxUpdate` must be empty"
+    );
+}