From: Steve Myers <steve@notmandatory.org>
Date: Thu, 21 Nov 2024 03:23:08 +0000 (-0600)
Subject: Merge bitcoindevkit/bdk#1730: Check time when persisting in `rusqlite` impl
X-Git-Tag: v1.0.0-beta.6~14
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/static/struct.CommandStringError.html?a=commitdiff_plain;h=b77739615d77d55266666d1225d67181b978baeb;p=bdk

Merge bitcoindevkit/bdk#1730: Check time when persisting in `rusqlite` impl

8ec9c0a7495acc2cdc6f4444d1a1d3aca566b17b fix(chain): check time when persisting (Rob N)

Pull request description:

  Closes #1713

  Any implementation overflowing the `i64` type would be clearly faulty, so I just pass up the error if the conversion fails.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    ACK 8ec9c0a7495acc2cdc6f4444d1a1d3aca566b17b
  oleonardolima:
    utACK 8ec9c0a7495acc2cdc6f4444d1a1d3aca566b17b

Tree-SHA512: ded7c036f7a082e181e52f0366410f572227d57af37fdfd0fc0909f629a48ad1ed69f5c8549c45fe6c7aadb7e3fa62d2b56990028bc7fd321e43d39b79d77b00
---

b77739615d77d55266666d1225d67181b978baeb