From: 志宇 <hello@evanlinjin.me>
Date: Thu, 28 Nov 2024 10:49:28 +0000 (+1100)
Subject: Merge bitcoindevkit/bdk#1736: Sqlite - allow persisting anchor without tx
X-Git-Tag: v1.0.0-beta.6~10
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/static/struct.CommandStringError.html?a=commitdiff_plain;h=bf42562be7a9924aa83917a3339786d444509972;p=bdk

Merge bitcoindevkit/bdk#1736: Sqlite - allow persisting anchor without tx

18f5f3fa21f5e83dab9e30a5f536e5526883d580 test(sqlite): test persisting anchors and txs independently (valued mammal)
297ff3414909ae42d34c31f5c942fc81aa1d60f9 test(chain): add test `insert_anchor_without_tx` (valued mammal)
e69d10e7d387ffc96876b4290131d8fa9d4dd8ff doc(chain): document module `rusqlite_impl` (valued mammal)
8fa899b74619b549e4880c28a0f1d348cb68f755 fix(chain): Sqlite - allow persisting anchor without tx (志宇)

Pull request description:

  ### Description

  Previously, we may error when we insert an anchor where the txid being anchored has no corresponding tx.

  closes #1712
  replaces #961

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK 18f5f3fa21f5e83dab9e30a5f536e5526883d580
  ValuedMammal:
    ACK 18f5f3fa21f5e83dab9e30a5f536e5526883d580

Tree-SHA512: 7343eff857016f684cfb9f7af57f7be56ba36c70c36b8b4303159636f79ad5cc49a6f94354443323c9aa05c31ec7d43c22b038d9e41361596c3a346bd6a94b10
---

bf42562be7a9924aa83917a3339786d444509972