]> Untitled Git - bdk-cli/commit
Merge bitcoindevkit/bdk-cli#61: Improve error handlings.
authorSteve Myers <steve@notmandatory.org>
Sun, 12 Dec 2021 02:07:58 +0000 (18:07 -0800)
committerSteve Myers <steve@notmandatory.org>
Sun, 12 Dec 2021 02:09:05 +0000 (18:09 -0800)
commitf3d126efc1f63b9d3d0b253d9c90d5d98e9a15b0
tree39e4ee982b06694ed5809dc0bc940d663b5b7fd3
parentceafbedf0ed9dbb02ce04dcddfe2602e724ef1b8
parent7e65add3e342747c1f0e0e0cbbf1539db30b36e4
Merge bitcoindevkit/bdk-cli#61: Improve error handlings.

7e65add3e342747c1f0e0e0cbbf1539db30b36e4 Handle errors properly instead of unwraps. (rajarshimaitra)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  bdk-cli had lots of ugly unwraps through out the code. All the unwraps inside the library (except tests) were removed and errors were propagated with `bdk::Error` type.

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

Top commit has no ACKs.

Tree-SHA512: 5c4a46af66341e300ac25339a402ea6ba9c8b81172873dc1b7ab5fa081fcbd6546fe2e372acce2a2b6f227034159724e8fc083e02c598de6a44cc4f843e1f07f