From: Steve Myers Date: Mon, 20 Nov 2023 23:33:48 +0000 (-0800) Subject: Merge bitcoindevkit/bdk#1204: chore: remove bdk dependency on log and dev dependency... X-Git-Tag: v1.0.0-alpha.3~14 X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/struct.Encoder.html?a=commitdiff_plain;h=73862be3ba331a667b3b9908b3db0b445460f849;p=bdk Merge bitcoindevkit/bdk#1204: chore: remove bdk dependency on log and dev dependency on env_logger 02fa34089623ea43e9c62003e3b829d10dec5a14 chore: remove bdk dependency on log and dev dependency on env_logger (Steve Myers) Pull request description: ### Description As suggested by @TheBlueMatt we shouldn't use the `log` crate because even though it is a rust-lang project is may depend on some other crates that aren't as well maintained. Since we were only use `log` in a few places and not it any other bdk workspace projects except the `bdk` package I removed it. ### Notes to the reviewers For consistency I also removed the `env_logger` from the dev dependencies since it was only being used in a few places in a couple examples and println! is adequate for examples. ### Changelog notice None ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing Top commit has no ACKs. Tree-SHA512: beb9e4d465112090093590c45e3e5e2286a99a819312512eb3e5b40d0eade9740314bb8e45a2ad3fa0a4c86e32711d2ef8f966842815874b9315fd0b63bc7283 --- 73862be3ba331a667b3b9908b3db0b445460f849