From: Steve Myers <steve@notmandatory.org>
Date: Thu, 21 Nov 2024 03:00:26 +0000 (-0600)
Subject: Merge bitcoindevkit/bdk#1732: chore(core)!: rename `SyncResult` to `SyncResponse`
X-Git-Tag: v1.0.0-beta.6~17
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/struct.InsertBlockNotMatchingError.html?a=commitdiff_plain;h=d949fe4c73d8b56f255e1d4e72545651446b5313;p=bdk

Merge bitcoindevkit/bdk#1732: chore(core)!: rename `SyncResult` to `SyncResponse`

3b03c7bed2d132fbcdb027a8445f47f0b85d99fa chore(core)!: rename `FullScanResult` to `FullScanResponse` (Leonardo Lima)
1411cb8d58f669054c10c0dcfe67e6b271368544 chore(core)!: rename `SyncResult` to `SyncResponse` (Leonardo Lima)

Pull request description:

  fixes #1647

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  As mentioned in #1647 issue, the usage of `Result` in Rust is conventionally meant to be an enum type with error variant, and it's appropriate here.

  It should be `SyncResponse` instead, as it's the most appropriate alongside the other types `SyncRequest` and `SyncProgress` already being used.

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  - Change `bdk_core::spk_client`'s `SyncResult` to `SyncResponse`.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    reACK 3b03c7bed2d132fbcdb027a8445f47f0b85d99fa

Tree-SHA512: b18c44b73f21d318f9f5f61417c0244a5b1c3cea9cab6490084edb380495e58d6e078b48b4e106bb2749b08da4f4e260b497ad482342b8fb7ee9b5e5dff2e4aa
---

d949fe4c73d8b56f255e1d4e72545651446b5313