From: Steve Myers <steve@notmandatory.org>
Date: Fri, 22 Nov 2024 01:03:41 +0000 (-0600)
Subject: Merge bitcoindevkit/bdk#1734: chore(chain)!: use `debug_assert!` on `apply_update`
X-Git-Tag: v1.0.0-beta.6~12
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/struct.InvalidCharacterError.html?a=commitdiff_plain;h=03c73686360959b1e6c4238ca2483ca7ab255328;p=bdk

Merge bitcoindevkit/bdk#1734: chore(chain)!: use `debug_assert!` on `apply_update`

2ec5aa488e9317d027d9625c1a4222e8c384b38e chore(chain)!: use `debug_assert!` on `apply_update` (Leonardo Lima)

Pull request description:

  fixes #1689

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description
  As mentioned in issue #1689 the `debug_assert!` is being used on other `LocalChain` methods, such as: `from_changeset`, and `apply_changeset` but it was missing on `apply_update`.

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  - Add usage of `debug_assert!()` to `LocalChain::apply_update`.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 2ec5aa488e9317d027d9625c1a4222e8c384b38e Thank you @oleonardolima
  notmandatory:
    ACK 2ec5aa488e9317d027d9625c1a4222e8c384b38e

Tree-SHA512: 31ac1accc825fb2b9ecfde38e43c2a662f933cfc0b8488775276ca770a5cce1d61a20ad8ba689327ed264252ad2f3ae10c9baba462a22f567395df493fb24886
---

03c73686360959b1e6c4238ca2483ca7ab255328