From: valued mammal <valuedmammal@protonmail.com>
Date: Tue, 1 Oct 2024 23:17:27 +0000 (-0400)
Subject: Merge bitcoindevkit/bdk#1636: ci: fix build-test job with --no-default-features,... 
X-Git-Tag: v1.0.0-beta.5~2
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/struct.NetworkValidationError.html?a=commitdiff_plain;h=b8746c8506568497acc2b6b5f6ab7017537e6b29;p=bdk

Merge bitcoindevkit/bdk#1636: ci: fix build-test job with --no-default-features, add miniscript/no-std

0e8082437401eccdef30737e739381d295530547 ci: fix build-test job with --no-default-features, add miniscript/no-std (Steve Myers)

Pull request description:

  ### Description

  Fixes the CI `build-test` job with `--no-default-features` by also adding `--features miniscript/no-std`.

  Until `rust-miniscript` removes the `no-std` feature we need to enable it when `--no-default-features` is used to build `bdk_wallet` or the whole workspace. See also the `check-no-std` job which does the same plus enables the `bdk_chain/hashbrown` feature which is also needed to build `bdk_wallet` with `--no-default-features` but is already enabled when building the whole workspace.

  ### Notes to the reviewers

  I think we didn't catch this on #1625 because the CI job names changed and I didn't update the branch merge requirements. Another possibility is it was passing because of cached build artifacts which I removed last night when I was trying to troubleshoot something else. I've updated the required CI jobs that need to pass before allowing a PR to be merged to `master` to include the ones with `--no-default-features --features bdk_chain/hashbrown` in the name.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [ ] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  ValuedMammal:
    ACK 0e8082437401eccdef30737e739381d295530547

Tree-SHA512: 5da486b7fd988575b6f9c06eb108a183b47c74d58fd451453d77b53ad26f58890ee605f4a154922688dc348bc5a3c413dcd9128fd4831d8923c64a33aa4a951c
---

b8746c8506568497acc2b6b5f6ab7017537e6b29