]> Untitled Git - bdk/commit
refactor(wallet)!: remove TxOrdering::Bip69Lexicographic
authornymius <155548262+nymius@users.noreply.github.com>
Tue, 25 Jun 2024 23:20:54 +0000 (20:20 -0300)
committerSteve Myers <steve@notmandatory.org>
Fri, 5 Jul 2024 20:03:08 +0000 (15:03 -0500)
commit3bee563c810ace941e0e80ee8e410d843a05f5d8
tree3d9a129c27b434833eab4d1c9d389bfa26f7fae1
parente5cb7b206619f5f3437e5ee95ed3e53885b745e6
refactor(wallet)!: remove TxOrdering::Bip69Lexicographic

BIP 69 proposed a deterministic way to sort transaction inputs and
outputs with the idea of enhancing privacy. It was later discovered
there was no such enhancement but rather a decrement in privacy due to
this sorting.
To avoid the promotion of bad practices, the
TxOrdering::Bip69Lexicographic variant which implemented this BIP for
BDK is removed with this change.
Notice that you can still produce a BIP 69 compliant transaction
defining order functions for TxOrdering::Custom.

Signed-off-by: Steve Myers <steve@notmandatory.org>
crates/wallet/src/wallet/tx_builder.rs
crates/wallet/tests/wallet.rs