From: keerthi <keerthi.sree2105@gmail.com>
Date: Thu, 10 Apr 2025 09:21:26 +0000 (+0530)
Subject: fix(electrum): improve tx validation and gap limit scanning
X-Git-Tag: bitcoind_rpc-0.21.0~17^2~4
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/trait.SliceRandom.html?a=commitdiff_plain;h=b57768dd2bd25d4fc9d6acc3990b04fa8594e7b1;p=bdk

fix(electrum): improve tx validation and gap limit scanning
---

diff --git a/crates/electrum/src/bdk_electrum_client.rs b/crates/electrum/src/bdk_electrum_client.rs
index f4ab32b2..4e89fdb8 100644
--- a/crates/electrum/src/bdk_electrum_client.rs
+++ b/crates/electrum/src/bdk_electrum_client.rs
@@ -339,6 +339,10 @@ impl<E: ElectrumApi> BdkElectrumClient<E> {
                     }
                 }
             }
+
+            if unused_spk_count >= stop_gap {
+                break;
+            }
         }
 
         Ok(last_active_index)
diff --git a/crates/electrum/tests/test_electrum.rs b/crates/electrum/tests/test_electrum.rs
index 7b6a63cd..1973b456 100644
--- a/crates/electrum/tests/test_electrum.rs
+++ b/crates/electrum/tests/test_electrum.rs
@@ -885,7 +885,7 @@ fn test_check_fee_calculation() -> anyhow::Result<()> {
 
 #[test]
 pub fn test_sync_performance() -> anyhow::Result<()> {
-    const EXPECTED_MAX_SYNC_TIME: Duration = Duration::from_secs(5);
+    const EXPECTED_MAX_SYNC_TIME: Duration = Duration::from_secs(15);
     const NUM_ADDRESSES: usize = 1000;
 
     let env = TestEnv::new()?;