From: Steve Myers <steve@notmandatory.org>
Date: Mon, 22 Jul 2024 02:29:41 +0000 (-0500)
Subject: Merge bitcoindevkit/bdk#1506: Standardize API ownership in `KeychainTxOutIndex`
X-Git-Tag: v1.0.0-beta.1~1
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/scripts/wallet/struct.AddressInfo.html?a=commitdiff_plain;h=5478bb1ebb22f6e33498baf9b25c634d85eef0e6;p=bdk

Merge bitcoindevkit/bdk#1506: Standardize API ownership in `KeychainTxOutIndex`

79262185d556009c3d3e918f886ba4a51a262351 refactor(chain)!: update KeychainTxOutIndex methods to use owned ScriptBuf (Steve Myers)
7c07b9de02edf9f2c2b8a153f7bc4c0ca0823b02 refactor(chain)!: update KeychainTxOutIndex methods to use owned K (Rob N)

Pull request description:

  ### Description

  Make all method signatures of `KeychainTxOutIndex` take owned `K` and use `ScriptBuf` instead of its borrowed counterpart `&Script`. Fixes #1482

  ### Notes to the reviewers

  Steve also added a CI fix as well

  ### Changelog notice

  - Make all method signatures of `KeychainTxOutIndex` take owned `K`
  - Update `KeychainTxOutIndex` methods to use `ScriptBuf`

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

Top commit has no ACKs.

Tree-SHA512: 3cb7d627ef6f38e1eaf6b88174f143c42dfc4d34e3d3d56cc843c256b2f32360fd00fa9ee328d0a41dac1f46771ccae797a96d9e3cee6f5ac4ef63e27cf6b7b7
---

5478bb1ebb22f6e33498baf9b25c634d85eef0e6