From: Alekos Filini Date: Wed, 6 Jul 2022 14:41:58 +0000 (+0200) Subject: Merge bitcoindevkit/bdk#648: test: BDK won't add unconf inputs when fee bumping X-Git-Tag: 0.20.0~9 X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/struct.EncoderStringWriter.html?a=commitdiff_plain;h=1c94108d7e597033214182d15cdb14a2cda241f9;p=bdk Merge bitcoindevkit/bdk#648: test: BDK won't add unconf inputs when fee bumping 5d00f8238886a993ef21056e5b3e216a4aae6951 test that BDK won't add unconf inputs when fee bumping (Daniela Brozzoni) 98748906f6799041341227de33bec20e8c6ef4b0 test: fix populate_test_db conf calculation (Daniela Brozzoni) 1d9fdd01faf3a0f17c57381a7c54d136e9d69ffe Remove wrong TODO comment in build_fee_bump (Daniela Brozzoni) Pull request description: ### Description Closes #144 ### Notes to reviewers #144 is describing a bug that doesn't seem to happen in BDK master anymore (BDK not respecting BIP125 rule 2). This PR just adds a test to check that the bug is fixed. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### Bugfixes: * [ ] This pull request breaks the existing API * [x] I've added tests to reproduce the issue which are now passing * [x] I'm linking the issue being fixed by this PR ACKs for top commit: afilini: ACK 5d00f8238886a993ef21056e5b3e216a4aae6951 Tree-SHA512: 95833f3566f9716762884d65f3f656346482e45525a3e92efa86710b9f574fdd9af7d235f1f425e4298d6ff380db9af60d1d2008ccde2588d971757db2d136b8 --- 1c94108d7e597033214182d15cdb14a2cda241f9