From: Silvestrs Timofejevs <silvestrs.timofejevs@crypto.com>
Date: Fri, 10 Feb 2023 07:39:51 +0000 (+0000)
Subject: Check results in the DB tests
X-Git-Tag: v1.0.0-alpha.0~7^2
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/database/struct.ReadError.html?a=commitdiff_plain;h=a1a70a50119fc4f02962cfffe29233e6d8fc116b;p=bdk

Check results in the DB tests

Checksum test was giving a false positive due to ignoring the return
value.

Other tests were giving assertion fail later in the test, rather than
an error on failed method call, thus making it more challenging to
debug the issue.

These have been discovered, when implementing PostgreSQL backend in
a downstream fork.
---

diff --git a/src/database/mod.rs b/src/database/mod.rs
index 7f26a132..bf53e94f 100644
--- a/src/database/mod.rs
+++ b/src/database/mod.rs
@@ -487,7 +487,7 @@ pub mod test {
 
         assert!(res.is_none());
 
-        let _res = db.set_script_pubkey(&script, keychain, path);
+        db.set_script_pubkey(&script, keychain, path).unwrap();
         let (chain, child) = db.del_path_from_script_pubkey(&script).unwrap().unwrap();
 
         assert_eq!(chain, keychain);
@@ -620,13 +620,13 @@ pub mod test {
     pub fn test_del_last_index<D: Database>(mut db: D) {
         let keychain = KeychainKind::External;
 
-        let _res = db.increment_last_index(keychain);
+        db.increment_last_index(keychain).unwrap();
 
         let res = db.get_last_index(keychain).unwrap().unwrap();
 
         assert_eq!(res, 0);
 
-        let _res = db.increment_last_index(keychain);
+        db.increment_last_index(keychain).unwrap();
 
         let res = db.del_last_index(keychain).unwrap().unwrap();
 
@@ -640,7 +640,7 @@ pub mod test {
         // insert checksum associated to keychain
         let checksum = "1cead456".as_bytes();
         let keychain = KeychainKind::External;
-        let _res = db.check_descriptor_checksum(keychain, checksum);
+        db.check_descriptor_checksum(keychain, checksum).unwrap();
 
         // check if `check_descriptor_checksum` throws
         // `Error::ChecksumMismatch` error if the