]> Untitled Git - bdk/commitdiff
Set tx field to none if `include_raw` is false
authorVladimir Fomene <vladimirfomene@gmail.com>
Tue, 13 Sep 2022 08:08:03 +0000 (11:08 +0300)
committerVladimir Fomene <vladimirfomene@gmail.com>
Tue, 13 Sep 2022 08:08:03 +0000 (11:08 +0300)
`del_tx` pulls the TransactionDetails object using
`select_transaction_details_by_txid` method which gets the transaction
details' data with a non-None transaction field even if the
`include_raw` argument is `false`. So it becomes necessary to Set
the transaction field in transactiondetails to None in `del_tx`, when
we make a call to it with `include_raw=false`.

src/database/sqlite.rs

index dc35b856ced383e43d13b5a7ec9572cae1a277a3..a9cbe1a7e729685045c344b6b0c3e713ed686ee0 100644 (file)
@@ -744,11 +744,13 @@ impl BatchOperations for SqliteDatabase {
         include_raw: bool,
     ) -> Result<Option<TransactionDetails>, Error> {
         match self.select_transaction_details_by_txid(txid)? {
-            Some(transaction_details) => {
+            Some(mut transaction_details) => {
                 self.delete_transaction_details_by_txid(txid)?;
 
                 if include_raw {
                     self.delete_transaction_by_txid(txid)?;
+                } else {
+                    transaction_details.transaction = None;
                 }
                 Ok(Some(transaction_details))
             }