From: 志宇 Date: Sun, 11 Feb 2024 09:48:42 +0000 (+0800) Subject: Merge bitcoindevkit/bdk#1335: fix(chain): tx_graph::ChangeSet::is_empty X-Git-Tag: v1.0.0-alpha.6~1 X-Git-Url: http://internal-gitweb-vhost/script/%22https:/struct.CommandStringError.html?a=commitdiff_plain;h=420e929463382ac08c811b2e559f64f26436be67;p=bdk Merge bitcoindevkit/bdk#1335: fix(chain): tx_graph::ChangeSet::is_empty 13ab5a835d59341e387fbbefec12fe4f48e5f3c8 chore(chain): Improve TxGraph::ChangeSet docs (LLFourn) dbbd51424284a960a95c3801b02dc1973322725f fix(chain)!: rm duplicate `is_empty` method in tx graph changeset (志宇) ae00e1ee7b95c622fc3992c0804dd4b4517efc7b fix(chain): tx_graph::ChangeSet::is_empty (LLFourn) Pull request description: 🙈 ### Changelog notice - Fix bug in `tx_graph::ChangeSet::is_empty` where is returns true even when it wasn't empty ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### Bugfixes: * [ ] This pull request breaks the existing API * [x] I've added tests to reproduce the issue which are now passing ACKs for top commit: LLFourn: Self-ACK: 13ab5a835d59341e387fbbefec12fe4f48e5f3c8 evanlinjin: ACK 13ab5a835d59341e387fbbefec12fe4f48e5f3c8 Tree-SHA512: b9f1f17fd2ed0f8e2337a8033e1cbd3e9f15b1ad4b32da3f0eb73a30913d6798e7a08d6b297d93bd08c2e1c388226e97648650ac636846b2c7aa95c3bcefbcfd --- 420e929463382ac08c811b2e559f64f26436be67