From: Alekos Filini <alekos.filini@gmail.com>
Date: Mon, 14 Dec 2020 16:14:24 +0000 (+0100)
Subject: Rename `ScriptType` to `KeychainKind`
X-Git-Tag: v0.1.0~14
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/struct.DecoderReader.html?a=commitdiff_plain;h=11465813ca8ae8fbfe08f802181c4c81d60b118a;p=bdk-cli

Rename `ScriptType` to `KeychainKind`

This avoids confusion with the "type of script".
---

diff --git a/src/cli.rs b/src/cli.rs
index b4f0b73..44f11d7 100644
--- a/src/cli.rs
+++ b/src/cli.rs
@@ -104,7 +104,7 @@ use bitcoin::{Address, OutPoint, Script, Txid};
 
 use crate::blockchain::log_progress;
 use crate::error::Error;
-use crate::types::ScriptType;
+use crate::types::KeychainKind;
 use crate::{FeeRate, TxBuilder, Wallet};
 
 /// Wallet global options and sub-command
@@ -479,14 +479,14 @@ where
             }
 
             let policies = vec![
-                external_policy.map(|p| (p, ScriptType::External)),
-                internal_policy.map(|p| (p, ScriptType::Internal)),
+                external_policy.map(|p| (p, KeychainKind::External)),
+                internal_policy.map(|p| (p, KeychainKind::Internal)),
             ];
 
-            for (policy, script_type) in policies.into_iter().filter_map(|x| x) {
+            for (policy, keychain) in policies.into_iter().filter_map(|x| x) {
                 let policy = serde_json::from_str::<BTreeMap<String, Vec<usize>>>(&policy)
                     .map_err(|s| Error::Generic(s.to_string()))?;
-                tx_builder = tx_builder.policy_path(policy, script_type);
+                tx_builder = tx_builder.policy_path(policy, keychain);
             }
 
             let (psbt, details) = wallet.create_tx(tx_builder)?;
@@ -526,12 +526,12 @@ where
             Ok(json!({"psbt": base64::encode(&serialize(&psbt)),"details": details,}))
         }
         WalletSubCommand::Policies => Ok(json!({
-            "external": wallet.policies(ScriptType::External)?,
-            "internal": wallet.policies(ScriptType::Internal)?,
+            "external": wallet.policies(KeychainKind::External)?,
+            "internal": wallet.policies(KeychainKind::Internal)?,
         })),
         WalletSubCommand::PublicDescriptor => Ok(json!({
-            "external": wallet.public_descriptor(ScriptType::External)?.map(|d| d.to_string()),
-            "internal": wallet.public_descriptor(ScriptType::Internal)?.map(|d| d.to_string()),
+            "external": wallet.public_descriptor(KeychainKind::External)?.map(|d| d.to_string()),
+            "internal": wallet.public_descriptor(KeychainKind::Internal)?.map(|d| d.to_string()),
         })),
         WalletSubCommand::Sign {
             psbt,