From: Steve Myers <steve@notmandatory.org>
Date: Mon, 14 Oct 2024 18:59:06 +0000 (-0500)
Subject: Merge bitcoindevkit/bdk#1612: Refactor: Move transaction testing utilities from ... 
X-Git-Tag: v1.0.0-beta.6~35
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/struct.DisplayArray.html?a=commitdiff_plain;h=ad59970be75461d7c68a3ba87fc524e89f54eaaf;p=bdk

Merge bitcoindevkit/bdk#1612: Refactor: Move transaction testing utilities from `crates/chain/tests/common` to `testenv` crate

88a8403707038264251b3e7fa18b8f21af8646ff refactor(test): move tx test utils to testenv (Vihiga Tyonum)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  This change moves all transaction testing utilities (macros and functions) from `crates/chain/tests/common` to `crates/testenv/tx_utils` to minimize duplication.

  Closes #1602

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 88a8403707038264251b3e7fa18b8f21af8646ff
  notmandatory:
    ACK 88a8403707038264251b3e7fa18b8f21af8646ff

Tree-SHA512: aa85c6683d44463e8858f18840fd628d98f54757edff85fe0489c7954fc56998456ce8069e328eff46e907235d092059975c10e420fe7dfe83e5cdd9b63fc8ed
---

ad59970be75461d7c68a3ba87fc524e89f54eaaf