]> Untitled Git - bdk/commit
Merge bitcoindevkit/bdk#1285: doc(wallet): improve docs for `Wallet::sent_and_received`
author志宇 <hello@evanlinjin.me>
Fri, 19 Jan 2024 15:37:59 +0000 (23:37 +0800)
committer志宇 <hello@evanlinjin.me>
Fri, 19 Jan 2024 15:38:26 +0000 (23:38 +0800)
commit8d916d7a10c2e4e18ce3bc1d4ae429a3d3ebdf07
treec96e00af05a3a90071126faba7f80738a175c1d7
parent3fa44a58ec348fe7fa413ca96e8bf744c6210647
parent08b745ec9f16fa8ef18b0d9c92feb9d8ab87a184
Merge bitcoindevkit/bdk#1285: doc(wallet): improve docs for `Wallet::sent_and_received`

08b745ec9f16fa8ef18b0d9c92feb9d8ab87a184 doc(wallet): improve docs for `Wallet::sent_and_received` (vmammal)

Pull request description:

  Thank you @thunderbiscuit for raising this issue. I noticed this method borrows the language from `SpkTxOutIndex::sent_and_received`, which this PR doesn't touch. I think in general it's desirable that methods in `bdk_chain` crate would refer to some of the core structures directly.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 08b745ec9f16fa8ef18b0d9c92feb9d8ab87a184

Tree-SHA512: 7f1285c4baa5fb56fd65baa5585bd343338de9988b941618a2b9ab628d869563f6f71ce842f936e7e1fb6a56f2f1e50fc3deaff858e830b7039888e4e496ce9a
crates/bdk/src/wallet/mod.rs