]> Untitled Git - bdk/commitdiff
Merge bitcoindevkit/bdk#1597: fix(wallet): do `check_wallet_descriptor` when creating...
authorSteve Myers <steve@notmandatory.org>
Wed, 11 Sep 2024 14:19:51 +0000 (09:19 -0500)
committerSteve Myers <steve@notmandatory.org>
Wed, 11 Sep 2024 14:20:06 +0000 (09:20 -0500)
5aecf4d6c48b75e610bbb9e31ad552878d797b5c fix(wallet): do `check_wallet_descriptor` when creating and loading (valued mammal)

Pull request description:

  Do `check_wallet_descriptor` for both external and internal descriptors when creating a wallet, and as a defensive measure also perform the check on the descriptors loaded from a changeset.

  fixes #1557

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK 5aecf4d6c48b75e610bbb9e31ad552878d797b5c

Tree-SHA512: c1503cc0350894cff762925276a2b5b94ac07155df8ff85c9277fb33001bc3137f479f1b8b1c5da4401a6a1b7184467915558e1fa761ae7ccef5d8886103cdad

1  2 
crates/wallet/src/wallet/mod.rs

Simple merge