From: Steve Myers <steve@notmandatory.org>
Date: Wed, 11 Sep 2024 14:19:51 +0000 (-0500)
Subject: Merge bitcoindevkit/bdk#1597: fix(wallet): do `check_wallet_descriptor` when creating... 
X-Git-Tag: v1.0.0-beta.3~5
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/struct.EncoderStringWriter.html?a=commitdiff_plain;h=a4b4946831903182cc2a540ab5bfc2c93fb5f00c;p=bdk

Merge bitcoindevkit/bdk#1597: fix(wallet): do `check_wallet_descriptor` when creating and loading

5aecf4d6c48b75e610bbb9e31ad552878d797b5c fix(wallet): do `check_wallet_descriptor` when creating and loading (valued mammal)

Pull request description:

  Do `check_wallet_descriptor` for both external and internal descriptors when creating a wallet, and as a defensive measure also perform the check on the descriptors loaded from a changeset.

  fixes #1557

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK 5aecf4d6c48b75e610bbb9e31ad552878d797b5c

Tree-SHA512: c1503cc0350894cff762925276a2b5b94ac07155df8ff85c9277fb33001bc3137f479f1b8b1c5da4401a6a1b7184467915558e1fa761ae7ccef5d8886103cdad
---

a4b4946831903182cc2a540ab5bfc2c93fb5f00c