From: Steve Myers Date: Thu, 29 Aug 2024 14:49:39 +0000 (-0500) Subject: Merge bitcoindevkit/bdk#1425: chore: add `print_stdout`/`print_stderr` lints to works... X-Git-Tag: v1.0.0-beta.3~15 X-Git-Url: http://internal-gitweb-vhost/script/%22https:/struct.EncoderStringWriter.html?a=commitdiff_plain;h=a8d52e658bd45eacca683b36d516950b40bb73e5;p=bdk Merge bitcoindevkit/bdk#1425: chore: add `print_stdout`/`print_stderr` lints to workspace level e063ad89bde62e60b10435260e736c66515bf447 fix(esplora+wallet+file_store): remove remaining `println!` usage (Leonardo Lima) b32b9447e089709b66f24d5700750f0aa6b8d6e1 chore(examples): allow `clippy::print_stdout` in examples (Leonardo Lima) b614237127ec1e760414fcc8ee7c4b0c77c62d46 fix(tests)!: remove println! usage from tests (Leonardo Lima) eaa1917a46245e177ad3e65b53e34c681f0043d0 chore: add `print_stdout`/`print_stderr` lints to workspace level (Leonardo Lima) Pull request description: potentially fixes #1362 ### Description It adds both `print_stdout` and `print_stderr` deny level lints on workspace level, but it does allow it on test fns through `clippy.toml` settings, and explicitly allow it on example code. ### Notes to the reviewers It currently has the setting allowing it on test fns, but open for discussion below. ### Changelog notice - Add both `print_stdout` and `print_stderr` deny level lints on workspace level ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [x] I've added tests for the new feature * [x] I've added docs for the new feature ACKs for top commit: notmandatory: ACK e063ad89bde62e60b10435260e736c66515bf447 Tree-SHA512: b3348efd86d09944eb36e4d87799eebc23f4e423861b3bad08365d286449f61b29ad332157eecfb7307191ef61d3b8285341e0ccb868581e54b570d6dd37547c --- a8d52e658bd45eacca683b36d516950b40bb73e5 diff --cc crates/chain/Cargo.toml index ab0670d5,0651e718..2cc2b44b --- a/crates/chain/Cargo.toml +++ b/crates/chain/Cargo.toml @@@ -12,10 -12,15 +12,13 @@@ readme = "README.md # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html + [lints] + workspace = true + [dependencies] bitcoin = { version = "0.32.0", default-features = false } +bdk_core = { path = "../core", version = "0.1", default-features = false } serde = { version = "1", optional = true, features = ["derive", "rc"] } - -# Use hashbrown as a feature flag to have HashSet and HashMap from it. -hashbrown = { version = "0.9.1", optional = true, features = ["serde"] } miniscript = { version = "12.0.0", optional = true, default-features = false } # Feature dependencies diff --cc crates/electrum/Cargo.toml index c807cf83,489d35a5..f65911f8 --- a/crates/electrum/Cargo.toml +++ b/crates/electrum/Cargo.toml @@@ -9,9 -9,12 +9,12 @@@ description = "Fetch data from electru license = "MIT OR Apache-2.0" readme = "README.md" + [lints] + workspace = true + [dependencies] -bdk_chain = { path = "../chain", version = "0.17.0" } -electrum-client = { version = "0.21", features = ["proxy"], default-features = false } +bdk_core = { path = "../core", version = "0.1" } +electrum-client = { version = "0.21", features = [ "proxy" ], default-features = false } [dev-dependencies] bdk_testenv = { path = "../testenv", default-features = false } diff --cc crates/esplora/Cargo.toml index d7e5290f,422cf99f..911c7a6e --- a/crates/esplora/Cargo.toml +++ b/crates/esplora/Cargo.toml @@@ -11,8 -11,11 +11,11 @@@ readme = "README.md # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html + [lints] + workspace = true + [dependencies] -bdk_chain = { path = "../chain", version = "0.17.0", default-features = false } +bdk_core = { path = "../core", version = "0.1", default-features = false } esplora-client = { version = "0.9.0", default-features = false } async-trait = { version = "0.1.66", optional = true } futures = { version = "0.3.26", optional = true } diff --cc crates/file_store/Cargo.toml index 8e8966bb,50f86c5b..29af6b70 --- a/crates/file_store/Cargo.toml +++ b/crates/file_store/Cargo.toml @@@ -10,8 -10,11 +10,11 @@@ keywords = ["bitcoin", "persist", "pers authors = ["Bitcoin Dev Kit Developers"] readme = "README.md" + [lints] + workspace = true + [dependencies] -bdk_chain = { path = "../chain", version = "0.17.0", features = [ "serde", "miniscript" ] } +bdk_chain = { path = "../chain", version = "0.18.0", features = [ "serde", "miniscript" ] } bincode = { version = "1" } serde = { version = "1", features = ["derive"] } diff --cc crates/hwi/Cargo.toml index 947bb835,154833f1..fdb14662 --- a/crates/hwi/Cargo.toml +++ b/crates/hwi/Cargo.toml @@@ -8,6 -8,9 +8,9 @@@ description = "Utilities to use bdk wit license = "MIT OR Apache-2.0" readme = "README.md" + [lints] + workspace = true + [dependencies] -bdk_wallet = { path = "../wallet", version = "1.0.0-beta.1" } -hwi = { version = "0.9.0", features = [ "miniscript"] } +bdk_wallet = { path = "../wallet", version = "1.0.0-beta.2" } +hwi = { version = "0.9.0", features = [ "miniscript" ] } diff --cc crates/testenv/Cargo.toml index 688f81fb,48fa1f6b..c6cef80a --- a/crates/testenv/Cargo.toml +++ b/crates/testenv/Cargo.toml @@@ -12,9 -12,12 +12,12 @@@ readme = "README.md # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html + [lints] + workspace = true + [dependencies] -bdk_chain = { path = "../chain", version = "0.17", default-features = false } -electrsd = { version = "0.28.0", features = ["bitcoind_25_0", "esplora_a33e97e1", "legacy"] } +bdk_chain = { path = "../chain", version = "0.18", default-features = false } +electrsd = { version = "0.28.0", features = [ "bitcoind_25_0", "esplora_a33e97e1", "legacy" ] } [features] default = ["std"] diff --cc crates/wallet/Cargo.toml index afdcf688,aa353170..7e4a16d0 --- a/crates/wallet/Cargo.toml +++ b/crates/wallet/Cargo.toml @@@ -12,14 -12,17 +12,17 @@@ authors = ["Bitcoin Dev Kit Developers" edition = "2021" rust-version = "1.63" + [lints] + workspace = true + [dependencies] rand_core = { version = "0.6.0" } -miniscript = { version = "12.0.0", features = ["serde"], default-features = false } -bitcoin = { version = "0.32.0", features = ["serde", "base64"], default-features = false } +miniscript = { version = "12.0.0", features = [ "serde" ], default-features = false } +bitcoin = { version = "0.32.0", features = [ "serde", "base64" ], default-features = false } serde = { version = "^1.0", features = ["derive"] } serde_json = { version = "^1.0" } -bdk_chain = { path = "../chain", version = "0.17.0", features = ["miniscript", "serde"], default-features = false } -bdk_file_store = { path = "../file_store", version = "0.14.0", optional = true } +bdk_chain = { path = "../chain", version = "0.18.0", features = [ "miniscript", "serde" ], default-features = false } +bdk_file_store = { path = "../file_store", version = "0.15.0", optional = true } # Optional dependencies bip39 = { version = "2.0", optional = true }