From: Steve Myers <steve@notmandatory.org>
Date: Thu, 9 Dec 2021 20:25:26 +0000 (-0800)
Subject: Merge bitcoindevkit/bdk-cli#56: [bug] Fix RPC tests
X-Git-Tag: v0.4.0~8
X-Git-Url: http://internal-gitweb-vhost/script/%22https:/struct.OddLengthStringError.html?a=commitdiff_plain;h=ceafbedf0ed9dbb02ce04dcddfe2602e724ef1b8;p=bdk-cli

Merge bitcoindevkit/bdk-cli#56: [bug] Fix RPC tests

e3f3c3a3d5fbd0e74510aa4a47356d23b070e6b0 Add rpc build and test in CI (rajarshimaitra)
74d2a71e30eae746069371e112f38e591681dbf8 Add missing RPC wallet option (rajarshimaitra)
808dd7cfe05f638e576711e12b9dab8e88c6279f Remove redundant wallet options (rajarshimaitra)

Pull request description:

  ### Description

  There was an inconsistency in `rpc` tests. The `RpcOpts` was missing from the wallet struct. This wasn't caught before because we didn't have `rpc` tests in CI. Fixed that too.

  Also removed redundant wallet options from feature gated tests.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    re-ACK  e3f3c3a

Tree-SHA512: c6413d52bd982e1d7162789e2645c8ad5b93abb312edecb4a231f59bbb2f3734cc0dbc8b2f07aaa2445f4f8513148e6f1905ee0214510e732cf754e8db4926fa
---

ceafbedf0ed9dbb02ce04dcddfe2602e724ef1b8